Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support css watermark rule #2156

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

lyu571
Copy link
Collaborator

@lyu571 lyu571 commented Sep 26, 2023

No description provided.

@lyu571 lyu571 added the run check run check label Sep 27, 2023
return
}

for _, rule := range response.Response.Rules {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response.Response.Rules 可能为空吗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能,range接受nil的

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit a1909e5 into master Sep 27, 2023
7 checks passed
@andrew-tx andrew-tx deleted the feat/support-css-watermark-rule branch September 27, 2023 07:30
hellertang pushed a commit that referenced this pull request Oct 10, 2023
* feat:support css watermark_rule

* feat:support css watermark_rule

* add e2e

* 1.fix golangci-lint issues
2.add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants