fix bug in node pool creation #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-tx
reviewed
Oct 7, 2023
| @@ -718,7 +718,7 @@ func composedKubernetesAsScalingConfigParaSerial(dMap map[string]interface{}, me | |||
|
|
|||
| if v, ok := dMap["data_disk"]; ok { | |||
| dataDisks := v.([]interface{}) | |||
| request.DataDisks = make([]*as.DataDisk, 0, len(dataDisks)) | |||
| //request.DataDisks = make([]*as.DataDisk, 0, len(dataDisks)) | |||
There was a problem hiding this comment.
这里看直接把 data_disk 参数去掉了，但是输入还有这个参数呢
There was a problem hiding this comment.
如果不设置data_disk 参数，就不初始化，如果设置data_disk 参数，会使用request.DataDisks = append(request.DataDisks, &dataDisk)初始化参数
andrew-tx
reviewed
Oct 7, 2023
| @@ -718,7 +718,7 @@ func composedKubernetesAsScalingConfigParaSerial(dMap map[string]interface{}, me | |||
|
|
|||
| if v, ok := dMap["data_disk"]; ok { | |||
| dataDisks := v.([]interface{}) | |||
| request.DataDisks = make([]*as.DataDisk, 0, len(dataDisks)) | |||
|
说下这次改动的根因和背景？ |
lyu571
reviewed
Oct 7, 2023
.changelog/2170.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bugfix | |||
|
release-note改下. @xiaokouliu |
hellertang
pushed a commit
that referenced
this pull request
Oct 10, 2023
Co-authored-by: alantlliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、fix bug in node pool creation