Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssl-datasource #2173

Merged
merged 9 commits into from
Oct 11, 2023
Merged

feat: ssl-datasource #2173

merged 9 commits into from
Oct 11, 2023

Conversation

WeiMengXS
Copy link
Collaborator

ssl datasource

@WeiMengXS WeiMengXS added run check run check and removed run check run check labels Oct 8, 2023
```hcl
data "tencentcloud_ssl_describe_host_cos_instance_list" "describe_host_cos_instance_list" {
certificate_id = "8u8DII0l"
resource_type = "cos"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的resource_type只能填写“cos”是吧

```hcl
data "tencentcloud_ssl_describe_host_cdn_instance_list" "describe_host_cdn_instance_list" {
certificate_id = "8u8DII0l"
resource_type = "cdn"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的resource_type只能填写“cdn”是吧

```hcl
data "tencentcloud_ssl_describe_host_api_gateway_instance_list" "describe_host_api_gateway_instance_list" {
certificate_id = "9Bpk7XOu"
resource_type = "apiGateway"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的resource_type只能填写“ apiGateway”是吧

}

d.SetId(helper.DataResourceIdsHash(ids))
output3, ok := d.GetOk("result_output_file")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥命名为output3呢

}

d.SetId(helper.DataResourceIdsHash(ids))
output3, ok := d.GetOk("result_output_file")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output3 同上

@WeiMengXS WeiMengXS force-pushed the feat/ssl-datasource branch 2 times, most recently from 1af2f5f to 7622a4a Compare October 11, 2023 11:18
@WeiMengXS WeiMengXS force-pushed the feat/ssl-datasource branch from 85ea143 to 2d628ad Compare October 11, 2023 11:36
Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 53aaba7 into master Oct 11, 2023
6 checks passed
@andrew-tx andrew-tx deleted the feat/ssl-datasource branch October 11, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants