Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cam permission boundary #2177

Merged
merged 2 commits into from
Oct 9, 2023
Merged

feat: cam permission boundary #2177

merged 2 commits into from
Oct 9, 2023

Conversation

WeiMengXS
Copy link
Collaborator

add resource cam permission boundary

@WeiMengXS WeiMengXS added the run check run check label Oct 8, 2023

const testAccCamUserPermissionBoundary = `

resource "tencentcloud_cam_user_permission_boundary_attachment" "user_permission_boundary" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解除绑定的e2e增加一个?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e 的流程已经包括了解绑,测试框架在测试过程中会自动执行delete,也就是解绑。

}
targetUin := idSplit[0]

if err := service.DeleteCamUserPermissionBoundaryById(ctx, targetUin); err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这个是把当前用户的所用的Policy都删除了,不应该是只解绑其中某个Policy吗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

边界权限只有一个

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 9e37bf3 into master Oct 9, 2023
7 checks passed
@andrew-tx andrew-tx deleted the feat/cam-user-permission branch October 9, 2023 04:47
hellertang pushed a commit that referenced this pull request Oct 10, 2023
* feat: cam permission boundary

* feat: changelog

---------

Co-authored-by: WeiMengXS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants