Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/using orderly_security_group_ids instead of the security_group_ids #2197

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Feat/using orderly_security_group_ids instead of the security_group_ids #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
503f3ce
using orderly_security_group_ids instead of the security_group_ids in…
lyu571 Oct 11, 2023
7dd30b1
add changelog and update doc
lyu571 Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2197.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/tencentcloud_kubernetes_cluster: Adjust the TKE doc example which refers to the security group of `auto_scaling_config`.
```
2 changes: 1 addition & 1 deletion tencentcloud/resource_tc_kubernetes_as_scaling_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ resource "tencentcloud_kubernetes_node_pool" "mynodepool" {
instance_type = var.default_instance_type
system_disk_type = "CLOUD_PREMIUM"
system_disk_size = "50"
security_group_ids = ["sg-24vswocp"]
orderly_security_group_ids = ["sg-24vswocp"]
instance_charge_type = "SPOTPAID"
spot_instance_type = "one-time"
spot_max_price = "1000"
Expand Down
4 changes: 2 additions & 2 deletions tencentcloud/resource_tc_kubernetes_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ resource "tencentcloud_kubernetes_node_pool" "example" {
instance_type = var.default_instance_type
system_disk_type = "CLOUD_PREMIUM"
system_disk_size = "50"
security_group_ids = [local.sg_id]
orderly_security_group_ids = [local.sg_id]

data_disk {
disk_type = "CLOUD_PREMIUM"
Expand Down Expand Up @@ -347,7 +347,7 @@ resource "tencentcloud_kubernetes_node_pool" "example" {
instance_type = var.default_instance_type
system_disk_type = "CLOUD_PREMIUM"
system_disk_size = "50"
security_group_ids = [local.sg_id]
orderly_security_group_ids = [local.sg_id]

data_disk {
disk_type = "CLOUD_PREMIUM"
Expand Down
16 changes: 8 additions & 8 deletions website/docs/r/kubernetes_cluster.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,10 @@ resource "tencentcloud_kubernetes_node_pool" "example" {
multi_zone_subnet_policy = "EQUALITY"

auto_scaling_config {
instance_type = var.default_instance_type
system_disk_type = "CLOUD_PREMIUM"
system_disk_size = "50"
security_group_ids = [local.sg_id]
instance_type = var.default_instance_type
system_disk_type = "CLOUD_PREMIUM"
system_disk_size = "50"
orderly_security_group_ids = [local.sg_id]

data_disk {
disk_type = "CLOUD_PREMIUM"
Expand Down Expand Up @@ -352,10 +352,10 @@ resource "tencentcloud_kubernetes_node_pool" "example" {
multi_zone_subnet_policy = "EQUALITY"

auto_scaling_config {
instance_type = var.default_instance_type
system_disk_type = "CLOUD_PREMIUM"
system_disk_size = "50"
security_group_ids = [local.sg_id]
instance_type = var.default_instance_type
system_disk_type = "CLOUD_PREMIUM"
system_disk_size = "50"
orderly_security_group_ids = [local.sg_id]

data_disk {
disk_type = "CLOUD_PREMIUM"
Expand Down