Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import cluster #2339

Merged
merged 1 commit into from
Nov 30, 2023
Merged

import cluster #2339

merged 1 commit into from
Nov 30, 2023

Conversation

xiaokouliu
Copy link
Contributor

set up the cluster and import it into Terraform

@andrew-tx andrew-tx added the run check run check label Nov 23, 2023
@@ -1303,8 +1306,7 @@ func resourceTencentCloudTkeCluster() *schema.Resource {
"cluster_as_enabled": {
Type: schema.TypeBool,
ForceNew: true,
Optional: true,
Default: false,
Computed: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字段不能同时 ForceNew 和 Computed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除ForceNew

@andrew-tx andrew-tx added run check run check and removed run check run check labels Nov 25, 2023
Items []App `json:"items"`
}

type AppStatus struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个字段在腾讯云 SDK 里面没有定义吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk是没有相关的定义

Log *SwitchInfo `json:"Log,omitempty" name:"Log"`
}

type SwitchInfo struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个字段在腾讯云 SDK 没有定义吗

masters = append(masters, instanceInfo)
}
}
goto getMoreData
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否可以不用 goto

@@ -1596,6 +1597,9 @@ func resourceTencentCloudTkeCluster() *schema.Resource {
}
return
},
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段的意思是什么呢

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx added run check run check and removed run check run check labels Nov 30, 2023
@andrew-tx andrew-tx added run check run check and removed run check run check labels Nov 30, 2023
@andrew-tx andrew-tx merged commit 7264456 into tencentcloudstack:master Nov 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants