-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clb): [116078526]Support four-layer lb #2489
Conversation
46e5769
to
9c6a970
Compare
7bb4762
to
acff3be
Compare
a6df23e
to
31a21b5
Compare
@@ -21,7 +21,6 @@ func ResourceTencentCloudClbTargetGroupAttachments() *schema.Resource { | |||
return &schema.Resource{ | |||
Create: resourceTencentCloudClbTargetGroupAttachmentsCreate, | |||
Read: resourceTencentCloudClbTargetGroupAttachmentsRead, | |||
Update: resourceTencentCloudClbTargetGroupAttachmentsUpdate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里去掉 Update 是不兼容的变更?
@@ -31,15 +30,18 @@ func ResourceTencentCloudClbTargetGroupAttachments() *schema.Resource { | |||
"load_balancer_id": { | |||
Type: schema.TypeString, | |||
Optional: true, | |||
ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里加 ForceNew 是不兼容的变更?
@@ -0,0 +1,3 @@ | |||
```release-note:bug | |||
resource/tencentcloud_clb_target_group_attachments: Fixed the problem of not supporting four-layer LB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
四层 LB 好像在下面的代码中没体现出来?
a2694dc
to
9c00e63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1、add ForceNew
2、Fix empty parameters