Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clb): [116078526]Support four-layer lb #2489

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Conversation

WeiMengXS
Copy link
Collaborator

1、add ForceNew
2、Fix empty parameters

@WeiMengXS WeiMengXS changed the title fix: CLB [WIP] fix: CLB Jan 19, 2024
@WeiMengXS WeiMengXS force-pushed the fix/clb-location-id branch from 46e5769 to 9c6a970 Compare January 26, 2024 04:01
@WeiMengXS WeiMengXS changed the title [WIP] fix: CLB [WIP] [1070109406116106952]fix: CLB Feb 7, 2024
@WeiMengXS WeiMengXS changed the title [WIP] [1070109406116106952]fix: CLB fix(clb): [116078526]support four-layer lb Feb 22, 2024
@WeiMengXS WeiMengXS changed the title fix(clb): [116078526]support four-layer lb refactor(all): [116078526]Support four-layer lb Feb 22, 2024
@WeiMengXS WeiMengXS changed the title refactor(all): [116078526]Support four-layer lb fix(all): [116078526]Support four-layer lb Feb 22, 2024
@WeiMengXS WeiMengXS changed the title fix(all): [116078526]Support four-layer lb fix(clb): [116078526]Support four-layer lb Feb 22, 2024
@WeiMengXS WeiMengXS changed the title fix(clb): [116078526]Support four-layer lb [wip]fix(clb): [116078526]Support four-layer lb Feb 22, 2024
@WeiMengXS WeiMengXS changed the title [wip]fix(clb): [116078526]Support four-layer lb fix(clb): [116078526]Support four-layer lb Feb 23, 2024
@@ -21,7 +21,6 @@ func ResourceTencentCloudClbTargetGroupAttachments() *schema.Resource {
return &schema.Resource{
Create: resourceTencentCloudClbTargetGroupAttachmentsCreate,
Read: resourceTencentCloudClbTargetGroupAttachmentsRead,
Update: resourceTencentCloudClbTargetGroupAttachmentsUpdate,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里去掉 Update 是不兼容的变更?

@@ -31,15 +30,18 @@ func ResourceTencentCloudClbTargetGroupAttachments() *schema.Resource {
"load_balancer_id": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里加 ForceNew 是不兼容的变更?

@@ -0,0 +1,3 @@
```release-note:bug
resource/tencentcloud_clb_target_group_attachments: Fixed the problem of not supporting four-layer LB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

四层 LB 好像在下面的代码中没体现出来?

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit af9b033 into master Feb 28, 2024
8 checks passed
@andrew-tx andrew-tx deleted the fix/clb-location-id branch February 28, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants