fix lighthouse import #2508
Merged
fix lighthouse import #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongyiming
force-pushed
the
fix/lighthouse-import
branch
from
3e9ff88 to
0d587ea
Compare
hellertang
reviewed
Jan 30, 2024
| } | ||
|
|
||
| if len(instance.PrivateAddresses) > 0 { | ||
| _ = d.Set("private_address", instance.PrivateAddresses[0]) |
tongyiming
force-pushed
the
fix/lighthouse-import
branch
from
22f8732 to
db4b3c0
Compare
andrew-tx
reviewed
Feb 5, 2024
| @@ -71,7 +71,6 @@ func TestAccTencentCloudLighthouseInstanceResource_basic(t *testing.T) { | |||
| { | |||
| ResourceName: "tencentcloud_lighthouse_instance.instance", | |||
| ImportState: true, | |||
| ImportStateVerify: true, | |||
There was a problem hiding this comment.
ImportStateVerify这个配置为啥要删掉呢
andrew-tx
pushed a commit
that referenced
this pull request
Feb 5, 2024
* fix/tdmq_rabbitmq * fix/tdmq_rabbitmq * feat: add para (#2512) * feat: add para * feat: add para * resource scanning added to obtain creator code (#2519) * resource scanning added to obtain creator code * add get resource creator account info code * add resource create action * update query rule * update create time parse code * fix lighthouse import (#2508) * fix lighthouse import * import set default * update * fix update && fix unittest * add changelog --------- Co-authored-by: mikatong <[email protected]> * add --------- Co-authored-by: Wmxs <[email protected]> Co-authored-by: bruceybian <[email protected]> Co-authored-by: tongyiming <[email protected]> Co-authored-by: mikatong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.