Update cluster intranet and internet field config #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-tx
reviewed
Feb 5, 2024
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
这里是解决用户没有配置该字段时，再次apply产生change的问题，当去掉默认值，状态文件中的值会从查询接口中获取最新值，兼容用户原来的逻辑。如果用户这里配置了还是可能会产生change，这个目前无法避免。
There was a problem hiding this comment.
如果没有配置时，不是会使用默认值吗，再次 apply 时为啥会提示 change 呢
There was a problem hiding this comment.
这个网络配置现在有两个resource都可以修改（cluster和endpoint资源），当用户在cluster中没有配置，并通过endpoint开启网络时，再次apply时cluster会发生change
There was a problem hiding this comment.
这个网络配置现在有两个resource都可以修改（cluster和endpoint资源），当用户在cluster中没有配置，并通过endpoint开启网络时，再次apply时cluster会发生change
针对这个场景，去掉 Default 后，是不是一样会有这个问题呢
There was a problem hiding this comment.
cluster中去掉默认值，增加Computed，如果用户没配置那么每次apply后会从查询接口中写入就不会有这个change问题，如果配置了以用户配置的为准
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.