feat(iacExtInfo): [116337119] Adjusting the client structure #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der-tencentcloud into feat/iacExtInfo2
…der-tencentcloud into feat/iacExtInfo2
…der-tencentcloud into feat/iacExtInfo2
SevenEarth
changed the title
SevenEarth
changed the title
…der-tencentcloud into feat/iacExtInfo2
…der-tencentcloud into feat/iacExtInfo2
andrew-tx
reviewed
Mar 14, 2024
.changelog/2544.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:enhancement | |||
| resource/client: Adjusting the client structure | |||
| @@ -295,14 +295,28 @@ func (me *TencentCloudClient) UseTencentCosClient(bucket string) *cos.Client { | |||
| } | |||
|
|
|||
| // UseMysqlClient returns mysql(cdb) client for service | |||
| func (me *TencentCloudClient) UseMysqlClient() *cdb.Client { | |||
| func (me *TencentCloudClient) UseMysqlClient(iacExtInfo ...IacExtInfo) *cdb.Client { | |||
| iacExtInfoStr = ReqClient | ||
| } | ||
|
|
||
| request.Header.Set("X-TC-RequestClient", iacExtInfoStr) |
There was a problem hiding this comment.
这里为啥要把 extinfo 塞给 "X-TC-RequestClient" 请求头呢，不应该是把 ReqClient 塞给 "X-TC-RequestClient" 吗
tencentcloud/connectivity/client.go
Outdated
| if me.wafConn != nil { | ||
| if len(iacExtInfo) != 0 { |
tencentcloud/connectivity/client.go
Outdated
| return me.wafConn | ||
| } | ||
|
|
||
| cpf := me.NewClientProfile(300) | ||
| cpf.Language = "zh-CN" | ||
| me.wafConn, _ = waf.NewClient(me.Credential, me.Region, cpf) | ||
| me.wafConn.WithHttpTransport(&LogRoundTripper{}) | ||
| if len(iacExtInfo) != 0 { |
There was a problem hiding this comment.
这里应该只需要重新对 LogRoundTripper 赋值就行吧，me.wafConn.WithHttpTransport 的逻辑不用改吧
Co-authored-by: mikatong <[email protected]>
* add * add * fix/bh * fix/bh * fix/bh
* add * add * add * add * add * fix/bh
* add cvm uuid * add changelog
* add * add * add * Update resource_tc_private_dns_record.go
* fix/ckafka * fix/ckafka
* vod update * add changelog && update doc * update * update * update * update review_audio_video_task * update * update * update --------- Co-authored-by: mikatong <[email protected]>
* add eni ipv6 * add eni ipv6 * update doc * update doc * add test * add changelog
* add eni ipv4 * add eni ipv4 * add changelog
* support event config * add changelog --------- Co-authored-by: mikatong <[email protected]>
* Field cluster_subnet_id supports ForceNew * add changelog 2578.txt
* vod update * add changelog --------- Co-authored-by: mikatong <[email protected]>
* fix(mariadb): [116318703] support ip port * feat: add change log * fix: modify test
* feat(tse): [115375235] support tse network access_control * feat: add change log * fix: modify test * fix: modify test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/iacExtInfo2