Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(private_dns): [116458440] Add ForceNew attribute to domain parameter #2555

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

SevenEarth
Copy link
Collaborator

fix/private_dns

@SevenEarth SevenEarth added the run check run check label Mar 8, 2024
@SevenEarth SevenEarth changed the title fix(private_dns): [*] Add ForceNew attribute to domain parameter [WIP] fix(private_dns): [*] Add ForceNew attribute to domain parameter Mar 8, 2024
@SevenEarth SevenEarth changed the title [WIP] fix(private_dns): [*] Add ForceNew attribute to domain parameter fix(private_dns): [*] Add ForceNew attribute to domain parameter Mar 8, 2024
@SevenEarth SevenEarth changed the title fix(private_dns): [*] Add ForceNew attribute to domain parameter fix(private_dns): [116458440] Add ForceNew attribute to domain parameter Mar 8, 2024
@@ -29,6 +29,7 @@ func ResourceTencentCloudPrivateDnsZone() *schema.Resource {
"domain": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是不兼容变更吧

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 54ec823 into master Mar 8, 2024
10 of 12 checks passed
@andrew-tx andrew-tx deleted the fix/private_dns branch March 8, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants