feat(tke): [116471075]optimize cluster instance queries #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-tx
reviewed
Mar 13, 2024
| } | ||
| log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), response.ToJsonString()) | ||
| for { | ||
| if total >= 0 && offset >= total { |
There was a problem hiding this comment.
total >=0说明存在数据，然后判断offset >= total以结束循环
| } | ||
| log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), response.ToJsonString()) | ||
|
|
||
| if total < 0 { |
There was a problem hiding this comment.
获取所有数据数量存入total
There was a problem hiding this comment.
去掉 if total < 0 { 这段会有问题吗
There was a problem hiding this comment.
如果去掉，每次都会给total赋值，加上判断只会在第一次查询后赋值，当然去掉也没问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.