Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update readme and scripts with url #198

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: update readme and scripts with url #198

wants to merge 1 commit into from
+323 −101

Conversation

cutecutecat
Copy link
Member

docs(README)

  • add dependency of pgvector
  • fix vector_cos_ops to vector_cosine_ops
  • update image version

chore(bench scripts)

  • fix incorrect QPS count at parallel requests
    • when workers > 32, QPS will be overestimated
  • send the same whole data to all requests, instead of split data for parallel requests
    • for dataset laion-100, 1000 split to 128 parts will be have a huge negative impact on query startup
  • use dburl instead of local password

@cutecutecat cutecutecat requested a review from VoVAllen February 27, 2025 08:21
xieydd
xieydd reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@xieydd xieydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some content? I even didn't know how to create a table and directly created an index.

@VoVAllen
Copy link
Member

Let's recommend user to use ghcr.io instead of docker hub

@VoVAllen
Copy link
Member

Add can you also add an installation section with the link to the doc site?

@cutecutecat cutecutecat marked this pull request as draft February 27, 2025 08:35
@xieydd
Copy link
Member

xieydd commented Feb 27, 2025

Add can you also add an installation section with the link to the doc site?

yep, we need this, install from pkg.

@cutecutecat cutecutecat force-pushed the readme-scripts branch 24 times, most recently from 2054a05 to 9737f50 Compare March 4, 2025 03:22
@cutecutecat cutecutecat force-pushed the readme-scripts branch 25 times, most recently from e0947d7 to 625389d Compare March 4, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xieydd xieydd xieydd left review comments

@VoVAllen VoVAllen Awaiting requested review from VoVAllen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cutecutecat @VoVAllen @xieydd