Bugfix for NaN gradients in SPH lighting fitting. #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_368066194
branch
3 times, most recently
from
538f0aa to
cabc12b
Compare
copybara-service
bot
force-pushed
the
test_368066194
branch
from
cabc12b to
f1183b1
Compare
copybara-service
bot
force-pushed
the
test_368066194
branch
3 times, most recently
from
df59c32 to
9cd0fef
Compare
Perfectly camera aligned normals(0.0, 0.0, 1.0), results in some edge case computations in both the Legendre polynomial and cartesian to spherical calculations. This change introduces epsilon values in those cases to ensure NaNs are not generated. PiperOrigin-RevId: 368066194
copybara-service
bot
force-pushed
the
test_368066194
branch
from
9cd0fef to
6b1fd84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for NaN gradients in SPH lighting fitting.
Perfectly camera aligned normals(0.0, 0.0, 1.0), results in some edge case computations in both the Legendre polynomial and cartesian to spherical calculations. This change introduces epsilon values in those cases to ensure NaNs are not generated.