Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shift to consume script name before passing to application #1435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmc5179
Copy link

@dmc5179 dmc5179 commented Sep 4, 2019

The Dockerfile entrypoint /usr/bin/tf_serving_entrypoint.sh calls tensorflow_model_server with "$@" which results in an error message from tensorflow_model_server that "/usr/bin/tf_serving_entrypoint.sh" is not a supported option. This is because "$@" passes the first parameter which is the name of the script itself. To resolve this simply add the shift command to consume the first argument and then pass "$@" to tensorflow_model_server.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dmc5179
Copy link
Author

dmc5179 commented Sep 4, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 4, 2019
@netfs netfs self-requested a review November 18, 2020 04:23
@netfs
Copy link
Collaborator

netfs commented Nov 18, 2020

the fix looks correct, but i am puzzled why the instructions here:

https://github.com/tensorflow/serving#serve-a-tensorflow-model-in-60-seconds

do not yield any error. do you know why?

@dmc5179
Copy link
Author

dmc5179 commented Nov 20, 2020

This was awhile ago but IIRC I was troubleshooting other issues with my model and noticed this error in the logs. I don't think the error actually causes the process/container to fail. It simply complains that the first option is no good and moves onto the next one. But again, this was awhile ago so I'd have to run through it again and see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants