This repository has been archived by the owner on Sep 14, 2021. It is now read-only.
update to latest tjfs-core and get build working again #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been out of the loop of the new tfjs-core, @tafsiri can you or someone else have a look into this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. discussion in #76, this is a start at getting tfjs-tsne working with the latest tfjs-core. (At @stitchfix, we really want the Web Worker & OffscreenCanvas support that's now in tfjs-core!)
This branch successfully builds the library (with some hacks like the tsconfig.json change to
suppressImplicitAnyIndexErrors👀 ), but when I link it into a consuming app I get the same error reported in #77: "Failed to link vertex and fragment shaders"Perhaps this branch can be a jumping off point for someone who knows the tfjs-core API better than I do? (Which is not at all!)
This change is