Fix a linker error: undefined kMaxSmallSize #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with a recent version of xt-clang and -std=c++11, the linker errs on missing definition of a static constexpr class member. In C++11, static class members still had to be defined in a C++11 file and TFLM code is expected to be compatible with C++11. BUG=323856831
|
This PR needs to be submitted in the Tensorflow repository. The reason is that the file being changed is currently being synched daily from TensorFlow Lite. FYI, the list of TFLite synched files is here. |
|
Per our OOB conversation, this definition can be defined in runtime_shape.cc, as it is from the runtime_shape.h header. The runtime_shape.h header is not synced from TFLite. |
After discussing with the TFLM team, this file isn't sync-ed from the tflite repo, so we're free to create our own copy of the file.
rascani
approved these changes
Feb 27, 2024
rascani
added a commit
to rascani/tflite-micro
that referenced
this pull request
Feb 28, 2024
Despite existing in TFLite, the runtime_shape.h has long differed between TFLite and TFLM. The file is not copied during the sync and the sync script does a `git checkout` on the file to ensure that the existing version in the TFLM tree remains. In PR tensorflow#2476, we needed to add a runtime_shape.cc file. This PR ensures that the runtime_shape.cc file will not be removed during the sync by performing a `git checkout` on the existing file. BUG=323856831
rascani
added a commit
that referenced
this pull request
Feb 28, 2024
Despite existing in TFLite, the runtime_shape.h has long differed between TFLite and TFLM. The file is not copied during the sync and the sync script does a `git checkout` on the file to ensure that the existing version in the TFLM tree remains. In PR #2476, we needed to add a runtime_shape.cc file. This PR ensures that the runtime_shape.cc file will not be removed during the sync by performing a `git checkout` on the existing file. BUG=323856831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with a recent version of xt-clang and -std=c++11, the linker errs on missing definition of a static constexpr class member. In C++11, static class members still had to be defined in a C++11 file and TFLM code is expected to be compatible with C++11.
BUG=323856831