-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/remove redundant call to sidecar #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tensorplex-validator
merged 17 commits into
dev
from
fix/remove-redundant-call-to-sidecar
Apr 14, 2025
Merged
Fix/remove redundant call to sidecar #102
tensorplex-validator
merged 17 commits into
dev
from
fix/remove-redundant-call-to-sidecar
Apr 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tensorplex-validator
commented
Apr 12, 2025
- Query average completion time in DB instead of loading the full table and calculate on each submission of tasks results request
- Added resource profiling of each route to log the performance the routes
- Changed handleMetricData function into a single go-routine instead of multiple go routines
- Updated the context used within handleMetricData to timeout in 30 seconds, so that no phantom go routines will be alive even after the request context is over
chore: update metrics endpoint (#100)
Redefine task modality and migration script
… TotalHotkeyAlpha.
…nstead of multiple go routines.
…timeout as well so we can clear any hanging goroutines.
… calculate everytime.
…t gets killed once the request is done.
…t gets killed once the request is done.
…s to call resource profiling middleware via top level.
codebender37
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.