Make port optional

tenstad · Apr 30, 2021 · 8a762b6 · 8a762b6
1 parent 562d31a
commit 8a762b6
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 20 deletions.
diff --git a/internal/provider/data_source_remotefile.go b/internal/provider/data_source_remotefile.go
@@ -20,6 +20,17 @@ func dataSourceRemotefile() *schema.Resource {
 				Description: "Connection to host where files are located.",
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
+						"host": {
+							Type:        schema.TypeString,
+							Required:    true,
+							Description: "The target host.",
+						},
+						"port": {
+							Type:        schema.TypeInt,
+							Optional:    true,
+							Default:     22,
+							Description: "The ssh port to the target host.",
+						},
 						"username": {
 							Type:        schema.TypeString,
 							Required:    true,
@@ -31,16 +42,6 @@ func dataSourceRemotefile() *schema.Resource {
 							Sensitive:   true,
 							Description: "The private key used to login to the target host.",
 						},
-						"host": {
-							Type:        schema.TypeString,
-							Required:    true,
-							Description: "The target host.",
-						},
-						"port": {
-							Type:        schema.TypeInt,
-							Required:    true,
-							Description: "The ssh port to the target host.",
-						},
 					},
 				},
 			},

diff --git a/internal/provider/data_source_remotefile_test.go b/internal/provider/data_source_remotefile_test.go
@@ -34,6 +34,11 @@ func TestAccDataSourceRemotefile(t *testing.T) {
 
 const testAccDataSourceRemotefile = `
 data "remotefile" "bar" {
+	conn {
+		host = "localhost"
+		username = "root"
+		private_key = ""
+	}
 	path = "/tmp/bar.txt"
 }
 `
diff --git a/internal/provider/resource_remotefile.go b/internal/provider/resource_remotefile.go
@@ -25,6 +25,17 @@ func resourceRemotefile() *schema.Resource {
 				Description: "Connection to host where files are located.",
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
+						"host": {
+							Type:        schema.TypeString,
+							Required:    true,
+							Description: "The target host.",
+						},
+						"port": {
+							Type:        schema.TypeInt,
+							Optional:    true,
+							Default:     22,
+							Description: "The ssh port to the target host.",
+						},
 						"username": {
 							Type:        schema.TypeString,
 							Required:    true,
@@ -36,16 +47,6 @@ func resourceRemotefile() *schema.Resource {
 							Sensitive:   true,
 							Description: "The private key used to login to the target host.",
 						},
-						"host": {
-							Type:        schema.TypeString,
-							Required:    true,
-							Description: "The target host.",
-						},
-						"port": {
-							Type:        schema.TypeInt,
-							Required:    true,
-							Description: "The ssh port to the target host.",
-						},
 					},
 				},
 			},

diff --git a/internal/provider/resource_remotefile_test.go b/internal/provider/resource_remotefile_test.go
@@ -25,6 +25,11 @@ func TestAccResourceRemotefile(t *testing.T) {
 
 const testAccResourceRemotefile = `
 resource "remotefile" "foo" {
+  conn {
+	  host = "localhost"
+	  username = "root"
+	  private_key = ""
+  }
   path = "/tmp/foo.txt"
   content = "bar"
   permissions = "0777"