Fix bugs introduced in fa3a0b2

src/server/world/Bridge/BridgeModuleGenerator.cs

@@ -90,7 +90,7 @@ ReadOnlyMemory<byte> CreateModule(BridgeModuleKind kind, int seed)
                 {
                     _modules.Clear();
 
-                    var serverKind = _hostEnvironment.IsDevelopment()
+                    var clientKind = _hostEnvironment.IsDevelopment()
                         ? BridgeModuleKind.Normal
                         : BridgeModuleKind.Hardened;
 
@@ -100,7 +100,7 @@ ReadOnlyMemory<byte> CreateModule(BridgeModuleKind kind, int seed)
 
                         _modules.Add(
                             (BridgeModuleActivator.Create(CreateModule(BridgeModuleKind.Normal, seed)),
-                             CreateModule(serverKind, seed)));
+                             CreateModule(clientKind, seed)));
                     }
                 }
 

src/server/world/Bridge/BridgeModulePatchingPass.cs

@@ -69,11 +69,9 @@ void PatchPacketCodeSequences<T>()
                 insns.Add(Instruction.Create(OpCodes.Ret));
             }
 
-            switch ((method.DeclaringType.Name.String, method.Name.String))
+            switch (((string)method.DeclaringType.Name, (string)method.Name))
             {
-                case ("GameProtection", "Initialize") or
-                     ("PatchableBridgeProtectionComponent", "Start") or
-                     ("PatchableBridgeProtectionComponent", "Stop") when kind == BridgeModuleKind.Normal:
+                case ("GameProtection", "Initialize") when kind == BridgeModuleKind.Normal:
                 {
                     insns.Clear();
                     insns.Add(Instruction.Create(OpCodes.Ret));

src/shared/module/PatchableBridgeModule.cs

@@ -1,3 +1,5 @@
+using Arise.Bridge.Protection;
+
 namespace Arise.Bridge;
 
 public sealed class PatchableBridgeModule : BridgeModule
@@ -9,4 +11,9 @@ public sealed class PatchableBridgeModule : BridgeModule
     public override PatchableBridgeProtocolComponent Protocol { get; } = new();
 
     public override PatchableBridgeWatchdogComponent Watchdog { get; } = new();
+
+    public PatchableBridgeModule()
+    {
+        GameProtection.Initialize();
+    }
 }

src/shared/module/PatchableBridgeProtectionComponent.cs

@@ -4,28 +4,19 @@ namespace Arise.Bridge;
 
 public sealed class PatchableBridgeProtectionComponent : BridgeProtectionComponent
 {
-    private readonly IEnumerable<GameProtectionTask> _tasks = new GameProtectionTask[]
-    {
-        new CodeChecksumTask(),
-        new DebuggerDetectionTask(),
-    };
+    private readonly Queue<GameProtectionTask> _tasks = new();
 
-    [Obfuscation]
     public override void Start()
     {
-        // This method body is erased by the server's BridgeModuleGenerator for module instances that run on the server
-        // and for module instances running on the client in development scenarios.
+        _tasks.Enqueue(new CodeChecksumTask());
+        _tasks.Enqueue(new DebuggerDetectionTask());
 
         foreach (var task in _tasks)
             task.Start();
     }
 
-    [Obfuscation]
     public override void Stop()
     {
-        // This method body is erased by the server's BridgeModuleGenerator for module instances that run on the server
-        // and for module instances running on the client in development scenarios.
-
         foreach (var task in _tasks.Reverse())
             task.Stop();
     }

src/shared/module/Protection/GameProtection.cs

@@ -4,12 +4,17 @@ namespace Arise.Bridge.Protection;
 
 internal static class GameProtection
 {
+    private static int _initialized;
+
     [Obfuscation]
     public static void Initialize()
     {
         // This method body is erased by the server's BridgeModuleGenerator for module instances that run on the server
         // and for module instances running on the client in development scenarios.
 
+        if (Interlocked.Exchange(ref _initialized, 1) == 1)
+            return;
+
         var culture = CultureInfo.InvariantCulture;
 
         if (DateTime.UtcNow - DateTime.Parse(GetIssueTime(), culture) > TimeSpan.Parse(GetValidDuration(), culture))

src/shared/module/Protection/GameProtectionTask.cs

@@ -48,6 +48,8 @@ private static int GetCheckInterval()
 
     private async Task PerformCheckAsync(CancellationToken cancellationToken)
     {
+        await _ready.Task.ConfigureAwait(false);
+
         Initialize();
 
         while (!cancellationToken.IsCancellationRequested)