Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user feedback when job versions don't match master #3516

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jan 4, 2024

earl will now display feedback when running tjm start, update, or register if the following conditions are met:

  • The job in question is running on a Kubernetes cluster
  • The job file includes a kubernetes_image field with an expected image/tag format
    • A valid image tag format would be my-registry/teraslice:v[version of teraslice]
    • example: johnsregistry/teraslice:v0.73.11-nodev18.18.2
  • The master teraslice pod is running a different version of teraslice than the specified kubernetes_image

Here is an example of registering a job file that has "kubernetes_image": "terascope/teraslice:v0.73.11-nodev18.18.2" adnd the master pod is running on teraslice v0.89.0:

user@user teraslice % earl tjm register localhost test-job.json                                                     
yarn run v1.22.19
--------
Teraslice Master is running a different version of teraslice than this job
Job Name: test-job-es
Teraslice Master -> v0.89.0 || Current Job -> v0.73.11
--------
Successfully registered test-job-es on http://localhost:5678 with job id 61d6ec37-b051-44c9-8eb3-1e7fac54a700
✨  Done in 1.52s.

Ref to issue #3507

@sotojn sotojn self-assigned this Jan 4, 2024
@sotojn sotojn requested review from godber, ciorg and busma13 January 4, 2024 18:18
@sotojn sotojn changed the title [DRAFT] Add user feedback when job versions don't match master Add user feedback when job versions don't match master Jan 11, 2024
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, has @ciorg had a chance to provide feedback and has his concerns been addressed?

@ciorg
Copy link
Member

ciorg commented Jan 11, 2024

There hasn't been a commit since I reviewed it this morning - so I don't think anything has been changed yet.

@sotojn sotojn force-pushed the teraslice-cli-k8s-warn-feat branch from 909f629 to e7be397 Compare January 12, 2024 23:16
Copy link
Member

@ciorg ciorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciorg ciorg merged commit 4aa61ce into master Jan 13, 2024
39 checks passed
@ciorg ciorg deleted the teraslice-cli-k8s-warn-feat branch January 13, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants