Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main/telegram-bot-api): Switch to tag version control #21067

Closed
wants to merge 1 commit into from

Conversation

Sarisan
Copy link
Contributor

@Sarisan Sarisan commented Aug 7, 2024

No description provided.

@Sarisan
Copy link
Contributor Author

Sarisan commented Aug 7, 2024

Wasn't supposed to be opened now.

@Sarisan Sarisan closed this Aug 7, 2024
@Sarisan Sarisan reopened this Aug 7, 2024
@Sarisan Sarisan force-pushed the telegram-bot-api branch 3 times, most recently from 79ba9e9 to bc34852 Compare August 7, 2024 09:56
packages/telegram-bot-api/build.sh Outdated Show resolved Hide resolved
@Sarisan Sarisan requested a review from licy183 August 8, 2024 12:43
@Biswa96
Copy link
Member

Biswa96 commented Aug 8, 2024

The change is using a fork of the actual repository. I am not sure if that should be done.

@Sarisan
Copy link
Contributor Author

Sarisan commented Aug 8, 2024

The change is using a fork of the actual repository. I am not sure if that should be done.

I don't see any other way to implement auto updates for this packages, other than if there were tags, it would still require manipulations with git and submodule. I can actually try to ask developer to tag releases, but I doubt they will.

@Biswa96
Copy link
Member

Biswa96 commented Aug 8, 2024

Not all packages can be auto-updated. I would recommend maintaining the current version type if upstream does not have proper tags.

@Sarisan
Copy link
Contributor Author

Sarisan commented Aug 8, 2024

I will wait for developer response, closing this till then.
tdlib/telegram-bot-api#623

@Sarisan Sarisan closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants