Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support on_demand_throughput #90

Conversation

magreenbaum
Copy link
Member

Description

Support on_demand_throughput.

Motivation and Context

Closes: #89

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

main.tf Show resolved Hide resolved
Copy link

@v-greco v-greco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment about the default values ^_^

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit e47cf5f into terraform-aws-modules:master Oct 17, 2024
9 checks passed
@bryantbiggs
Copy link
Member

ugh - the release flow borked

@bryantbiggs
Copy link
Member

fixed through the GitHub UI and corrected the pull request settings to avoid similar errors in the future
image

@magreenbaum magreenbaum deleted the feat/on_demand_throughput branch October 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for "on_demand_throughput" parameter
3 participants