Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(E2E-minion): E2E-minion-crash-during-parallel-iPerf #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shrusti-W
Copy link

@Shrusti-W Shrusti-W commented Dec 28, 2022

Signed-off-by: Shrusti-W [email protected]

Prerequisites

  • I have read the Contributing Guidelines.
  • I have read the Code of Conduct.
  • If this is a non-trivial change, I have already opened an accompanying Issue.
  • If applicable, I have included documentation updates alongside my code changes.

Description

Introduced folly synchronization to iperfProcesses_ , iperfAvailablePorts_ and pingProcesses.

Modified the files
src/terragraph-e2e/e2e/minion/TrafficApp.cpp
src/terragraph-e2e/e2e/minion/TrafficApp.h

Test Plan

1.Tested iperf using the command
"tg traffic iperf start -s <source_mac> -d <dest_mac> -J"

2.Tested iperf by initiating 6 parallel sessions using the command
"tg traffic iperf start -s <source_mac> -d <dest_mac> -J"

3.Tested iperf for both TCP and UDP protocols using the command
UDP:"tg traffic iperf start -s <source_mac> -d <dest_mac> -J -p udp"
TCP:"tg traffic iperf start -s <source_mac> -d <dest_mac> -J -p tcp"

4.Tested iperf for duration of 5 hours to check the stability.

5.Tested ping using the command
"tg traffic ping start -s <source_mac> -d <dest_mac>"

6.Tested parallel ping by initiating 5 parallel session for 50 packets using the command
"tg traffic ping start -s <source_mac> -d <dest_mac> -c 50"

@facebook-github-bot
Copy link

Hi @Shrusti-W!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 28, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants