-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gha): fix macos action/setup-go@v4 cache miss. #1417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-terramate-io canceled.
|
i4ki
force-pushed
the
i4k-fix-macos-go-cache-miss
branch
2 times, most recently
from
February 2, 2024 02:46
1ec5ab9
to
71f30ad
Compare
|
i4ki
force-pushed
the
i4k-fix-macos-go-cache-miss
branch
from
February 2, 2024 03:08
71f30ad
to
0643d8d
Compare
wmalik
previously approved these changes
Feb 7, 2024
i4ki
force-pushed
the
i4k-fix-macos-go-cache-miss
branch
4 times, most recently
from
February 8, 2024 13:03
12d4f05
to
d74fd07
Compare
Signed-off-by: Tiago Natel <[email protected]>
i4ki
force-pushed
the
i4k-fix-macos-go-cache-miss
branch
from
February 9, 2024 21:18
93c384b
to
f33ce22
Compare
Now Go cache is restored successfully for MacOS:
|
soerenmartius
approved these changes
Feb 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set the same Go version as specified in the
go.mod
because of many similar issues related to the setup-go
cache unable to work when go.mod specifies a different
version.
Additionally, the rand.Seed() was updated to use
rand.New(rand.NewSource(seed)) because the former was
removed from Go1.20.
Which issue(s) this PR fixes:
no
Special notes for your reviewer:
Does this PR introduce a user-facing change?