Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prismlauncher: move JREs to weak deps, add java 21 for snapshots #1040

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

getchoo
Copy link
Contributor

@getchoo getchoo commented Apr 3, 2024

24w14a bumped the java requirement to 21, so this is required now. JREs are also now "weak" dependencies, as they don't all need to be installed (or even these specific JREs, though they are still "recommended")

@korewaChino
Copy link
Contributor

hold on, weird infra issue causing build failures.

lemme just deal with this and then merge so everything builds at the same time

@korewaChino korewaChino merged commit 045b6b3 into terrapkg:frawhide Apr 4, 2024
10 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

💔 All backports failed

Status Branch Result
f38 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.
f39 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.
f40 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.

Manual backport

To create the backport manually run:

backport --pr 1040

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

lleyton pushed a commit to lleyton/packages that referenced this pull request Apr 4, 2024
lleyton pushed a commit to lleyton/packages that referenced this pull request Apr 4, 2024
lleyton pushed a commit to lleyton/packages that referenced this pull request Apr 4, 2024
@lleyton
Copy link
Member

lleyton commented Apr 4, 2024

💚 All backports created successfully

Status Branch Result
f38
f39
f40

Questions ?

Please refer to the Backport tool documentation

Copy link

github-actions bot commented Apr 4, 2024

💔 All backports failed

Status Branch Result
f38 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.
f39 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.
f40 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.

Manual backport

To create the backport manually run:

backport --pr 1040

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

💔 All backports failed

Status Branch Result
f38 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.
f39 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.
f40 Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.

Manual backport

To create the backport manually run:

backport --pr 1040

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
raboneko pushed a commit that referenced this pull request Apr 4, 2024
raboneko pushed a commit that referenced this pull request Apr 4, 2024
raboneko added a commit that referenced this pull request Apr 4, 2024
…) (#1041)

(cherry picked from commit 045b6b3)

Co-authored-by: seth <[email protected]>
Co-authored-by: Raboneko <[email protected]>
@getchoo getchoo deleted the java21 branch November 28, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants