fix(nim-nightly): fixed package name #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lleyton
requested changes
Apr 20, 2024
Signed-off-by: madomado <[email protected]>
lleyton
requested changes
Apr 20, 2024
There was a problem hiding this comment.
pretty sure dist tag isn't needed, also you might want to provides for the "broken name", just in case, see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages
Signed-off-by: madomado <[email protected]>
lleyton
requested changes
Apr 20, 2024
There was a problem hiding this comment.
set the release in the obsoletes to be one higher than the last build of the faulty package
Take %{?dist} into account: When deciding what $obsEVR should be, remember that it needs to be higher than the previous Release:, including the %{?dist} suffix. Example: if the package previously had the release tag of -4.fcNN, the release specified in $obsEVR should be at least 5.
lleyton
approved these changes
Apr 21, 2024
raboneko
pushed a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 37416a0)
raboneko
pushed a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 37416a0)
raboneko
pushed a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 37416a0)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
madonuko
added a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 37416a0) Co-authored-by: madomado <[email protected]>
madonuko
added a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 37416a0) Co-authored-by: madomado <[email protected]>
madonuko
added a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 37416a0) Co-authored-by: madomado <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.