Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prismlauncher-nightly] Use system libs #1376

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

runlevel5
Copy link
Contributor

No description provided.

@madonuko madonuko enabled auto-merge (squash) June 19, 2024 16:21
madonuko
madonuko previously approved these changes Jun 19, 2024
@madonuko
Copy link
Member

Could you also force push signed commits?

@korewaChino
Copy link
Contributor

Please sign your commits.

@runlevel5
Copy link
Contributor Author

Could you also force push signed commits?
Okay let me

auto-merge was automatically disabled June 20, 2024 06:12

Head branch was pushed to by a user without write access

@runlevel5 runlevel5 force-pushed the patch-1 branch 2 times, most recently from 0fb6622 to f972302 Compare June 20, 2024 06:15
@runlevel5
Copy link
Contributor Author

$ git commit --amend -S
$ git push -f

Should be good now I guess

@madonuko
Copy link
Member

$ git commit --amend -S
$ git push -f

Should be good now I guess

I don't think you enabled gpg signing:

git config --global commit.gpgsign 1
git config --global user.signingkey <insert your signing key>

@runlevel5
Copy link
Contributor Author

$ git log --show-signature
commit 476f737fb3dfab416f8ad83098101d6a8fe9264f (HEAD -> patch-1, origin/patch-1)
Good "git" signature for [email protected] with RSA key SHA256:EJIYLZxugDIJ0Z56usDfeS5o90Ln/V0SCEGFWG+YfSM
Author: Trung Lê <[email protected]>
Date:   Wed Jun 19 23:15:12 2024 +1000

    [prismlauncher-nightly] Use system libs

    Signed-off-by: Trung Lê <[email protected]>

should be good now mate

@madonuko madonuko enabled auto-merge (squash) June 20, 2024 09:03
@madonuko madonuko merged commit c44ad50 into terrapkg:frawhide Jun 20, 2024
4 checks passed
raboneko pushed a commit that referenced this pull request Jun 20, 2024
Signed-off-by: Trung Lê <[email protected]>
(cherry picked from commit c44ad50)
raboneko pushed a commit that referenced this pull request Jun 20, 2024
Signed-off-by: Trung Lê <[email protected]>
(cherry picked from commit c44ad50)
@raboneko
Copy link
Member

💚 All backports created successfully

Status Branch Result
f39
f40

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@madonuko
Copy link
Member

Thank you!

madonuko pushed a commit that referenced this pull request Jun 20, 2024
Signed-off-by: Trung Lê <[email protected]>
(cherry picked from commit c44ad50)

Co-authored-by: Trung Lê <[email protected]>
madonuko pushed a commit that referenced this pull request Jun 20, 2024
Signed-off-by: Trung Lê <[email protected]>
(cherry picked from commit c44ad50)

Co-authored-by: Trung Lê <[email protected]>
@runlevel5 runlevel5 deleted the patch-1 branch June 20, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants