Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submarine git pull #1451

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix: submarine git pull #1451

merged 3 commits into from
Jul 9, 2024

Conversation

korewaChino
Copy link
Contributor

@korewaChino korewaChino commented Jul 9, 2024

Fixes an issue on newer RPM versions, where we can't really do the git pull hack on the RPM builddir anymore, thanks to https://rpm-software-management.github.io/rpm/manual/dynamic_specs.html

It's a cool feature, but it breaks our current script

@korewaChino korewaChino enabled auto-merge (squash) July 9, 2024 05:01
@korewaChino korewaChino requested review from lleyton and madonuko and removed request for lleyton July 9, 2024 05:03
@lleyton
Copy link
Member

lleyton commented Jul 9, 2024

aarch?

@korewaChino
Copy link
Contributor Author

korewaChino commented Jul 9, 2024

aarch?

Doesn't built on aarch upstream either, requires new release for this or some kind of OpenSSL header magic

@korewaChino korewaChino merged commit 6e2287f into frawhide Jul 9, 2024
3 of 4 checks passed
@korewaChino korewaChino deleted the fix/submarine/rawhide branch July 9, 2024 05:49
raboneko pushed a commit that referenced this pull request Jul 9, 2024
* fix: submarine git pull

* fix: create empty directory

* oops, we only popd once

(cherry picked from commit 6e2287f)
raboneko pushed a commit that referenced this pull request Jul 9, 2024
* fix: submarine git pull

* fix: create empty directory

* oops, we only popd once

(cherry picked from commit 6e2287f)
@raboneko
Copy link
Member

raboneko commented Jul 9, 2024

💚 All backports created successfully

Status Branch Result
f39
f40

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

madonuko pushed a commit that referenced this pull request Jul 9, 2024
* fix: submarine git pull

* fix: create empty directory

* oops, we only popd once

(cherry picked from commit 6e2287f)

Co-authored-by: Cappy Ishihara <[email protected]>
madonuko pushed a commit that referenced this pull request Jul 9, 2024
* fix: submarine git pull

* fix: create empty directory

* oops, we only popd once

(cherry picked from commit 6e2287f)

Co-authored-by: Cappy Ishihara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants