-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't run zed tests by default #1786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madonuko
approved these changes
Jul 31, 2024
raboneko
pushed a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 662487b)
raboneko
pushed a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 662487b)
raboneko
pushed a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 662487b)
raboneko
pushed a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 662487b)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
lleyton
added a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 662487b) Co-authored-by: lea <[email protected]>
Merged
madonuko
pushed a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit 662487b) Co-authored-by: lea <[email protected]>
madonuko
pushed a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit 662487b) Co-authored-by: lea <[email protected]>
madonuko
pushed a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit 662487b) Co-authored-by: lea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the x86-64-lg CI is borked, and the standard GitHub runners fail to work because of lack of disk space. This lack of disk space issue seems to happen during the test phase. I'll switch it off of the large runners after I verify with a manual build.
For now, we're going to disable running tests by default. Obviously this isn't ideal (esp for nightly), but we don't have much other of a choice and upstream is generally pretty good about QAing.