Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for UV rotation mismatch on tables #127

Open
wants to merge 3 commits into
base: 1.21.x
Choose a base branch
from

Conversation

Khazoda
Copy link

@Khazoda Khazoda commented Oct 20, 2024

This is a partial fix for #124

This PR rotates the UVs of the east, west, up, down faces for all of the table models in order to align them with vanilla planks.
The table block doesn't have a FACING property, which makes this an easy fix.

This is the order of priority I assigned to whether or not I rotated a face's UV:

  1. Prioritize the top pattern matching with wooden planks
  2. Prioritize the side pattern to match the wooden planks
  3. Prioritize the side pattern to match the top pattern
  4. Prioritize the bottom pattern to match the side patterns

Following that priority I ended up with a near perfect match to vanilla planks, with only the down face not matching. It's usually not noticeable though, and matching the sides of the table is more important.

java_7t7eNbjz5J.mp4

I'll talk about why I didn't do the other plank blocks such as the Desk and Nightstand in the comments of #124

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants