feat: adds basic support for vector tiles / mapbox-style layers #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahennr
changed the title
simonseyock
approved these changes
Jan 10, 2025
src/parser/SHOGunApplicationUtil.ts
Outdated
Comment on lines
741
to
752
| private forEachLayer(groupLayer: OlLayerGroup, callback: (layer: OlLayer) => void) { | ||
| groupLayer.getLayers().forEach(childLayer => { | ||
| if (childLayer instanceof OlLayerGroup) { | ||
| this.forEachLayer(childLayer, callback); | ||
| } | ||
|
|
||
| if (childLayer instanceof OlLayer) { | ||
| callback(childLayer); | ||
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
what is this function used for?
There was a problem hiding this comment.
Good catch, this function is currently not used and can be removed.
|
🎉 This PR is included in version 10.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the work of @dnlkoch in #422 and the feature added for
ol7maintenance branch #658Plz review @terrestris/devs