Skip to content

Commit

Permalink
Remove AbortTask
Browse files Browse the repository at this point in the history
  • Loading branch information
Levi-Armstrong committed Sep 29, 2023
1 parent 5f650fb commit 35f4e5e
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 154 deletions.
14 changes: 1 addition & 13 deletions tesseract_task_composer/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ The final task that is called in a task graph if successful
Error Task
^^^^^^^^^^

The final task that is called in a task graph if error occurs
The final task that is called in a task graph if error occurs. Also can add `trigger_abort: true` if it should abort when this task is reached.

.. code-block:: yaml
Expand All @@ -485,18 +485,6 @@ The final task that is called in a task graph if error occurs
config:
conditional: false
Abort Task
^^^^^^^^^^

The task that is called if you want to abort everything

.. code-block:: yaml
AbortTask:
class: AbortTaskFactory
config:
conditional: false
Sync Task
^^^^^^^^^

Expand Down
1 change: 0 additions & 1 deletion tesseract_task_composer/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_CUR

add_library(
${PROJECT_NAME}_nodes
src/nodes/abort_task.cpp
src/nodes/done_task.cpp
src/nodes/error_task.cpp
src/nodes/remap_task.cpp
Expand Down

This file was deleted.

67 changes: 0 additions & 67 deletions tesseract_task_composer/core/src/nodes/abort_task.cpp

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
#include <tesseract_task_composer/core/task_composer_graph.h>
#include <tesseract_task_composer/core/task_composer_pipeline.h>

#include <tesseract_task_composer/core/nodes/abort_task.h>
#include <tesseract_task_composer/core/nodes/done_task.h>
#include <tesseract_task_composer/core/nodes/error_task.h>
#include <tesseract_task_composer/core/nodes/remap_task.h>
Expand All @@ -39,7 +38,6 @@

namespace tesseract_planning
{
using AbortTaskFactory = TaskComposerTaskFactory<AbortTask>;
using DoneTaskFactory = TaskComposerTaskFactory<DoneTask>;
using ErrorTaskFactory = TaskComposerTaskFactory<ErrorTask>;
using RemapTaskFactory = TaskComposerTaskFactory<RemapTask>;
Expand All @@ -59,8 +57,6 @@ namespace tesseract_planning::test_suite
using TestTaskFactory = TaskComposerTaskFactory<TestTask>;
}

// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TESSERACT_ADD_TASK_COMPOSER_NODE_PLUGIN(tesseract_planning::AbortTaskFactory, AbortTaskFactory)
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
TESSERACT_ADD_TASK_COMPOSER_NODE_PLUGIN(tesseract_planning::DoneTaskFactory, DoneTaskFactory)
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
Expand Down

0 comments on commit 35f4e5e

Please sign in to comment.