Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement InfluxDB 2.x target #136

Merged

Conversation

salatamartin
Copy link
Contributor

@salatamartin salatamartin commented Aug 21, 2023

Implementing support for InfluxDB 2.x by using the new client (https://github.com/influxdata/influxdb-client-js).

I tried to do it similarly as the InfluxDB 1.x target. The only real difference is in the tests, where I had to use regex for the body matching since the new client pushes data with timestamp and I didn't find a nice way of mocking the time there.

Resolves #25

@salatamartin salatamartin changed the title Implement InfluxDB 2.x target feat: Implement InfluxDB 2.x target Aug 21, 2023
@ASaiAnudeep
Copy link
Member

Hi @salatamartin ,

Thank you for the pull request! I'd like to suggest considering a different npm package that might offer a more lightweight solution for our needs. I recommend checking out the influxdb-v2 npm package, which is known for its minimal footprint, efficient performance and we can achieve the same functionality with a reduced impact on the overall application size and load times. It aligns well with our goal of keeping our application lean and responsive.

@salatamartin
Copy link
Contributor Author

salatamartin commented Aug 28, 2023

Thanks for pointing me to influxdb-v2 @ASaiAnudeep . I updated the pull request to use this package which simplified some other things too (ce973d1).

Let me know if you want me to squash the commits or anything...

@salatamartin
Copy link
Contributor Author

Hello @ASaiAnudeep,

can we proceed with this PR, please?

Thanks!

@ASaiAnudeep
Copy link
Member

I will take a look and merge it this week.

@ASaiAnudeep ASaiAnudeep self-requested a review October 21, 2023 12:26
@ASaiAnudeep ASaiAnudeep merged commit ba65102 into test-results-reporter:main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support InfluxDB v2 as target
3 participants