-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pin MongoDB images and improve test coverage for maintained versions #448
Conversation
…us args (deprecated since python3)
Funny, never would have occurred to me to call the init function! I am not sure how pythonic it is to do this manually since Could this be a version glitch where we didn't specify the version of the mongo dependency accurately enough, therefore it sucked up an unknown version? (remind me to create an issue for dependency management too, we should install |
none of my research ever turned up anything to explain how this fixes the issue but @covatic-john claims that this fixes the issue in this comment - #401 (comment) |
0026ae3
to
28840c8
Compare
looking at this PR once a week and cannot bring myself to merge it. it makes no sense. @covatic-john i did merge a different PR where it turns out there was no waiting at all for mongo container (i mean it usually starts in under 1sec in my experimence) so maybe it was that? maybe i will change my mind one of these weeks. at present, we have no indication that the issue went away, so leaving open. |
Having to call the There are no traces of the behavior happening in version 5.0+ in any of the tests, so I'll merge this now and see if it persist. If it does, then we should look into the platform arch for the users with problems and see if it might be the same errors as in #457, where the connection string itself might be formatted incorrectly. |
🤖 I have created a release *beep* *boop* --- ## [4.3.1](testcontainers-v4.3.0...testcontainers-v4.3.1) (2024-04-02) ### Bug Fixes * **core:** env vars not being respected due to constructor call ([#524](#524)) ([4872ea5](4872ea5)), closes [#521](#521) * Pin MongoDB images and improve test coverage for maintained versions ([#448](#448)) ([b5c7a1b](b5c7a1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for some reason this causes an issue, see #401 for details