Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(main): release testcontainers 4.0.1 #456

Merged
merged 2 commits into from
Mar 11, 2024
Merged

chore(main): release testcontainers 4.0.1 #456

merged 2 commits into from
Mar 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 9, 2024 •
edited by alexanderankin
Loading

🤖 I have created a release beep boop

4.0.1 (2024-03-11)

Features

  • postgres: Remove SqlAlchemy dependency from postgres container (#445) (f30eb1d)

Bug Fixes

  • clickhouse: clickhouse waiting (#428) (902a5a3)
  • Close docker client when stopping the docker container (#380) (efb1683)
  • failing tests for elasticsearch on machines with ARM CPU (#454) (701b23a)
  • mongodb: waiting for container to start (it was not waiting at all before?) (#461) (2c4f171)
  • unclosed socket warning in db containers (#378) (cd90aa7)
  • Update the copyright header for readthedocs (#341) (5bef18a)

This PR was generated with Release Please. See documentation.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--testcontainers branch from fe393bc to ff681ae Compare March 9, 2024 11:14
@alexanderankin
Copy link
Member

@totallyzen why did it do this ⁉️

@github-actions github-actions bot force-pushed the release-please--branches--main--components--testcontainers branch from ff681ae to 98e3f56 Compare March 9, 2024 11:23
@totallyzen
Copy link
Collaborator

@totallyzen why did it do this ⁉️

Hey! Think of this PR as "automatically collect pending changes that need releasing".

Therefore if there is no PR, the tool will auto-open a new PR.
If there is one, it updates the PR with the correct inferred semver update.

Since we used the fix(scope): something format then it inferred a patch version. This is very common.
If you want to avoid an update, then use chore(scope): my message and it won't appear. I believe this is configurable, but never needed to worry about it myself because you get used to what goes where very quickly.

What I can see it having right now, out of the 3 fixes it detected, 2 of them are real fixes worthy of a patch! We could in fact release the patch the coming week, as frequent releases yield better feedback from devs and showing the community that we respond to needs very quickly, IMO that's good!

The remaining fix could have been marked as test(exlasticsearch): fix execution on ARM machines or something.
I think you understand where this is coming from!

I'll make sure to add this in the docs as a link to release-please and how it infers stuff (and point at configuration too if it has overrides, I never needed to override this before).

@github-actions github-actions bot force-pushed the release-please--branches--main--components--testcontainers branch 3 times, most recently from 243f4cb to 894d9d9 Compare March 9, 2024 15:53
@github-actions github-actions bot changed the title chore(main): release testcontainers 4.0.1 chore(main): release testcontainers 4.1.0 Mar 10, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--testcontainers branch from 894d9d9 to 4db5c55 Compare March 10, 2024 22:30
@alexanderankin
Copy link
Member

haha i wonder how hard it would be for us to theoretically rename #445 to fix after the fact, i did not realize it had "feat" in the title - i did view it more as a fix personally

@github-actions github-actions bot force-pushed the release-please--branches--main--components--testcontainers branch from 4db5c55 to d72a361 Compare March 11, 2024 10:33
@alexanderankin alexanderankin changed the title chore(main): release testcontainers 4.1.0 chore(main): release testcontainers 4.0.1 Mar 11, 2024
@alexanderankin alexanderankin merged commit 5dcda88 into main Mar 11, 2024
9 checks passed
@alexanderankin alexanderankin deleted the release-please--branches--main--components--testcontainers branch March 11, 2024 11:21
@github-actions GitHub Actions
Copy link
Contributor Author

🤖 Release is at https://github.com/testcontainers/testcontainers-python/releases/tag/testcontainers-v4.0.1 🌻

bearrito pushed a commit to bearrito/testcontainers-python that referenced this pull request Mar 30, 2024
@github-actions @alexanderankin
chore(main): release testcontainers 4.0.1 (testcontainers#456)
177f9c7 
🤖 I have created a release *beep* *boop*
---


##
[4.0.1](testcontainers/testcontainers-python@testcontainers-v4.0.0...testcontainers-v4.0.1)
(2024-03-11)


### Features

* **postgres:** Remove SqlAlchemy dependency from postgres container
([testcontainers#445](testcontainers#445))
([f30eb1d](testcontainers@f30eb1d))


### Bug Fixes

* **clickhouse:** clickhouse waiting
([testcontainers#428](testcontainers#428))
([902a5a3](testcontainers@902a5a3))
* Close docker client when stopping the docker container
([testcontainers#380](testcontainers#380))
([efb1683](testcontainers@efb1683))
* failing tests for elasticsearch on machines with ARM CPU
([testcontainers#454](testcontainers#454))
([701b23a](testcontainers@701b23a))
* **mongodb:** waiting for container to start (it was not waiting at all
before?)
([testcontainers#461](testcontainers#461))
([2c4f171](testcontainers@2c4f171))
* unclosed socket warning in db containers
([testcontainers#378](testcontainers#378))
([cd90aa7](testcontainers@cd90aa7))
* Update the copyright header for readthedocs
([testcontainers#341](testcontainers#341))
([5bef18a](testcontainers@5bef18a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Ankin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autorelease: tagged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderankin @totallyzen