compiler: require ARMv8.1 #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nuno Cruces <[email protected]>
|
See wasilibs/go-re2#136 for an instance of this happening. |
mathetake
reviewed
Nov 19, 2024
mathetake
reviewed
Nov 19, 2024
mathetake
reviewed
Nov 19, 2024
mathetake
reviewed
Nov 19, 2024
internal/platform/cpuid_arm64.go
Outdated
| func loadCpuFeatureFlags() CpuFeatureFlags { | ||
| switch runtime.GOOS { | ||
| case "darwin", "windows": | ||
| // These OSes require ARMv8.1, which includes atomic instructions. |
There was a problem hiding this comment.
i get why darwin requires v8.1 by default (m series is so), but not sure about windows here. any reference or pointer?
There was a problem hiding this comment.
Windows 10 does not in fact require them, is it good enough to document this?
At least this change should not be a regression.
Signed-off-by: Nuno Cruces <[email protected]>
mathetake
approved these changes
Nov 20, 2024
|
cc @anuraaga fyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that Large System Extensions (atomic instructions) are supported on
arm64. These are included in many processors, and are part of ARMv8.1, which is required by macOS and Windows 11.This is similar to the check that the
amd64CPUs support SSE4.1 (which is part of x86-64-v2, and available on most processors).Biggest behavioral change is using
platform.CompilerSupported()to decide whether to (not) use the compiler onwazero.NewRuntimeConfig(), but I think this makes sense.