Added traits support #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added the fastcgi_finish_request() function
As of PHP 5.4, arrays can be declared as `[ ]`, so following PEAR's style guide, the contents of such arrays could be indented.
|
@infininight Hey Michael, would you mind taking a look at this? Thanks! |
|
I've added the indention fix, the first one puts items in files we regenerate periodically though, so they would get blown away when that gets updated. |
|
Thanks Michael! Where should I look into to have traits and |
|
Cool, will look into it and commit again. |
|
Open a new pull request or reopen this one when that is done. |
|
@unRob Any progress yet? :) |
|
None so far, I have to look into https://github.com/textmate/php.tmbundle/tree/master/Support/generate, but haven't had the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added the fastcgi_finish_request() function