Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two problems in 'Insert Call to Parent' #39

Closed
wants to merge 2 commits into from

Conversation

aurora
Copy link
Contributor

@aurora aurora commented Nov 29, 2013

My commits fix two problems, eg in the following example

class test{
    /**
     * ...
     * @param $parent[tab-trigger]
     */
    function test() {
    }
}

the replacement after tab-trigger for parent would have been:

class test{
    /**
     * ...
     * @param $
     */
    function test() {
    }
}
parent

which is of course wrong. The incorred placement is the fault of returning 'TM_EXIT_INSERT_TEXT' (203), i've removed this with my first commit. The second commit fixes the problem, that tab-expansion should not occur when tab is pressed after writing for example a variable named '$parent', by checking contents of 'TM_CURRENT_WORD'. Replacement should only be done, if this environment variable is empty.

@infininight
Copy link
Member

Pulled as 518b8b0 & 792be2b thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants