Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent tab-triggers for snippets when in phpdoc scope #40

Closed
wants to merge 2 commits into from

Conversation

aurora
Copy link
Contributor

@aurora aurora commented Nov 29, 2013

Currently tab-triggers for snippets are active in phpdoc, too, with the affect that snippets are inserted in documentation blocks, where you normally don't want to have them, for example:

class test {
    /**
     * ...
     * @param array[tab-trigger]
     */
    function test($arg) {
    }
}

expands to:

class test {
    /**
     * ...
     * @param $arrayName = array('' => , );
     */
    function test($arg) {
    }
}

My commit changes scope to "source.php - comment.block.documentation.phpdoc.php".

I was not sure, if i should really add it to all snippets or just for things like "array". I decided to apply the change to almost all relevant snippets, to stay consistent.

@aurora
Copy link
Contributor Author

aurora commented Dec 4, 2013

I think i have to withdraw this pull-request because i just noticed, that changing the tab-trigger scope isn't a good solution for this, because the html tab-triggers are still active ... so, i have to look for a better solution on this - imo - problem.

@aurora aurora closed this Dec 4, 2013
@aurora aurora deleted the phpdoc branch December 4, 2013 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant