Comments in function arguments

[mroch]

Fixes a bug where something like this will break highlighting for the rest of the file:

function my_vararg_function($foo/*, ... */) {
   ...
}

The problem is that the syntax looks for $foo followed by a comma or closing paren and does not allow a comment.

[joshvarner]

I believe this particular issue was fixed already in 1720dbc, and then a related issue was fixed in c2c2212. Perhaps the bundle you had been using had not been updated when you noticed this issue?

Please check out the latest in the official fork and see if you still see the issue. I'll leave the pull request open in the meantime, to make sure this is fixed for you.

[mroch]

Thanks for the quick response.

I did test this on the latest. The two commits you mention seem to fix the same problem for the case where last argument is typehinted (note how meta.function.argument.typehinted.php's end regex contains /[/*]|\# but the others don't), and when the comment comes before the argument (which the multi-line case collapses to when you remove whitespace).

[joshvarner]

Ah, okay. I understand now. I've merged/pushed your commit. I also noticed another potential usage that would break things:

function foo(array $bar = array(1, 2, /* test */ 3)) {}

I pushed 4820322 to fix that as well. Let me know how it works for you. Thanks for the patch!