feat(metrics): Add metrics.users.disabled flag #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfadeyi
force-pushed
the
disable-user-metrics-flag
branch
from
411e6ef to
ad06fdf
Compare
tfadeyi
force-pushed
the
disable-user-metrics-flag
branch
11 times, most recently
from
85a3fc8 to
801f948
Compare
hobbsh
reviewed
Dec 6, 2023
hobbsh
reviewed
Dec 6, 2023
.github/workflows/chart-testing.yaml
Outdated
| @@ -62,4 +62,8 @@ jobs: | |||
| with: | |||
| version: 'latest' | |||
| - name: Run chart-testing (install) | |||
| run: ct install --config chart-testing.yaml | |||
| run: ct install --config chart-testing.yaml --helm-extra-set-args '--set=exporter.tls.disabled=true --set=auth0.domain="${{ secrets.TEST_AUTH0_DOMAIN }}" --set=auth0.clientId="$CLIENT_ID" --set=auth0.clientSecret="$CLIENT_SECRET"' | |||
There was a problem hiding this comment.
You can also create ci/test-values.yaml in the root of the chart directory and chart-testing will use those when it installs. The format is just regular helm values, but only overrides from default values.yaml.
There was a problem hiding this comment.
If I had a ci/test-values.yaml is there a way I can populate the values in the yaml with the secrets in CI?
Maybe I could use envsubst, but I'm not 100% sure
There was a problem hiding this comment.
Oh I missed that bit - not unless you do some envsubst, sed, etc before the install step. The secrets would need to get written as a k8s secret and then referenced in the chart.
tfadeyi
force-pushed
the
disable-user-metrics-flag
branch
2 times, most recently
from
d784085 to
2aac16a
Compare
Introduces the `--metrics.users.disabled` flag, to disable user metrics like the monthly_active_users. It updates the helm chart. Signed-off-by: oluwole fadeyi <[email protected]>
tfadeyi
force-pushed
the
disable-user-metrics-flag
branch
from
2aac16a to
12649d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
--metrics.users.disabledflag, to disable user metrics like the monthly_active_users.