Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timeout): Add request timeout flag #147

Merged
merged 2 commits into from
Dec 20, 2023
Merged

feat(timeout): Add request timeout flag #147

merged 2 commits into from
Dec 20, 2023

Conversation

tfadeyi
Copy link
Owner

@tfadeyi tfadeyi commented Dec 20, 2023

📋 Changes

  • Adds a new flag, --web.timeout, to set the request timeout for the exporter webserver.
  • Update the helm chart to include the new flag.

📚 References

@tfadeyi tfadeyi force-pushed the 110-client-timeout branch 2 times, most recently from 29e38b0 to d2d1c43 Compare December 20, 2023 17:34
Adds a new flag, --web.timeout, to set the request timeout for the exporter webserver.
Update the helm chart to include the new flag.

Signed-off-by: oluwole fadeyi <[email protected]>
Signed-off-by: oluwole fadeyi <[email protected]>
@tfadeyi tfadeyi merged commit cd0a2c2 into main Dec 20, 2023
@tfadeyi tfadeyi deleted the 110-client-timeout branch December 20, 2023 18:05
@hobbsh
Copy link
Contributor

hobbsh commented Dec 20, 2023

Would this end up functionally the same as scrapeTimeout in a ServiceMonitor?

Timeout after which Prometheus considers the scrape to be failed.
If empty, Prometheus uses the global scrape timeout unless it is less than the target’s scrape interval value in which the latter is used.

@tfadeyi
Copy link
Owner Author

tfadeyi commented Dec 21, 2023

Would this end up functionally the same as scrapeTimeout in a ServiceMonitor?

Timeout after which Prometheus considers the scrape to be failed.

If empty, Prometheus uses the global scrape timeout unless it is less than the target’s scrape interval value in which the latter is used.

It is true, I wanted to make the exporter web server more configurable. I might still make the default, no timeout.

But I'll address some of the other points like the health check in separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants