Add formula for gr-iio #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgov
force-pushed
the
gr-iio
branch
2 times, most recently
from
58441c6 to
00921d9
Compare
|
The pull request has been updated to build Please see the two bullets above for potential improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a formula to install
gr-iio.It requires this change to Homebrew for the
gnuradioformula: Homebrew/homebrew-core#65437The formula is
HEAD-only because there is no release that builds with GNU Radio 3.8, which is what Homebrew offers. There is a patch needed to fix a compilation error that I cherry-pick frommasterbecause it has not yet landed inupgrade-3.8yet.Normally, a Homebrew formula should declares all of its Python package dependencies as
resourcesections to be installed bypip, as the mainlinegr-osmosdrformula does. However it doesn't look to me like there are any.There are two minor issues with the dependencies:
This wiki page says that building it requires
liborc-devon Linux, so I added theorcdependency as well, but I can't figure out if it is actually used?CMake seems to fail to detect MPIR but we build successfully anyway, so I marked it optional. This is something that probably needs to be fixed in
gr-iio's CMake configuration. (This needs to be resolved before upstreaming this tohomebrew-core.)