some minors

tfranzel · Oct 3, 2024 · d05e5be · d05e5be
1 parent 6f3a656
commit d05e5be
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 70 deletions.
diff --git a/drf_spectacular/plumbing.py b/drf_spectacular/plumbing.py
@@ -526,8 +526,8 @@ def safe_ref(schema: _SchemaType) -> _SchemaType:
 
 def append_meta(schema: _SchemaType, meta: _SchemaType) -> _SchemaType:
     if spectacular_settings.OAS_VERSION.startswith('3.1'):
-        schema = copy.deepcopy(schema)
-        meta = copy.deepcopy(meta)
+        schema = schema.copy()
+        meta = meta.copy()
 
         schema_nullable = meta.pop('nullable', None)
         meta_nullable = schema.pop('nullable', None)

diff --git a/tests/test_extend_schema.py b/tests/test_extend_schema.py
@@ -248,10 +248,13 @@ class XSerializer(serializers.Serializer):
     def view_func(request, format=None):
         pass  # pragma: no cover
 
-    assert_schema(
-        generate_schema('x', view_function=view_func),
-        'tests/test_extend_schema_field_with_dict_oas_3_1.yml'
-    )
+    schema = generate_schema('x', view_function=view_func)
+
+    assert schema['components']['schemas']['X']['properties'] == {
+        'field1': {'readOnly': True, 'type': ['string', 'null']},
+        'field2': {'readOnly': True, 'type': ['string', 'null']},
+        'field3': {'readOnly': True, 'type': ['string', 'null']}
+    }
 
 
 def test_layered_extend_schema_on_view_and_method_with_meta(no_warnings):

diff --git a/tests/test_extend_schema_field_with_dict_oas_3_1.yml b/tests/test_extend_schema_field_with_dict_oas_3_1.yml