Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional setting for enum suffixes #1140

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

jrbeaumont
Copy link
Contributor

Provide an ENUM_SUFFIX setting which allows for the option to define how enums will be named by default when automatically generated. This defaults to Enum to work with existing set ups.

This does not affect enums named in ENUM_NAME_OVERRIDE.

@jrbeaumont jrbeaumont changed the title Enum suffix Optional setting for enum suffixes Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c53b677) 98.63% compared to head (17f0888) 98.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1140   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          71       71           
  Lines        8698     8710   +12     
=======================================
+ Hits         8579     8591   +12     
  Misses        119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@tfranzel tfranzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff! thx @jrbeaumont

I was wondering why it took so long for anyone to ask for this. 😄

fyi this PR is incomplete. the same changes are also required in hooks.py.

@jrbeaumont
Copy link
Contributor Author

Thanks for the quick response @tfranzel! 😄

fyi this PR is incomplete. the same changes are also required in hooks.py.

I'm not sure I understand, hooks.py is what I have changed.

@tfranzel
Copy link
Owner

tfranzel commented Jan 5, 2024

I'm not sure I understand, hooks.py is what I have changed.

ahh sry, nevermind. I was just focused somewhere else and then that nonsense came out. 😆

@tfranzel tfranzel merged commit d275fcf into tfranzel:master Jan 5, 2024
35 checks passed
@jrbeaumont
Copy link
Contributor Author

Friday evening 😴 I know how you feel.

Thanks so much! Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants