Force evaluation of reverse_lazy urls in set_query_parameters. Fixes #1311 #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…franzel#1311 Passing reverse_lazy url to SpectacularRedocView errors because set_query_parameters calls urlls.parse.urlparse on url which may not be a string but a 'django.utils.functional.lazy.<locals>.__proxy__'. Forcing url to be string fixes this issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 74 74
Lines 9068 9069 +1
=======================================
+ Hits 8939 8940 +1
Misses 129 129 ☔ View full report in Codecov by Sentry. |
|
I figured you could squash and merge but re-reading the contributing I can rebase this and make it a single commit if you want. (Can't quite remember if squash and merge UI in github allows you to edit the squashed commit message) |
|
Hey @tfranzel is there anything I need to add to this PR that I'm missing? Please do let me know what's needed to have this merged. |
tfranzel
added a commit
that referenced
this pull request
Nov 30, 2024
Merged
tfranzel
added a commit
that referenced
this pull request
Nov 30, 2024
* Force evaluation of reverse_lazy urls in set_query_parameters. Fixes #1311 Passing reverse_lazy url to SpectacularRedocView errors because set_query_parameters calls urlls.parse.urlparse on url which may not be a string but a 'django.utils.functional.lazy.<locals>.__proxy__'. Forcing url to be string fixes this issue. * Update plumbing.py * fix second lazy url issue & add test #1312 --------- Co-authored-by: Işık Kaplan <[email protected]>
|
squash-merged in #1339. fixed another location and addded a test. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing reverse_lazy url to SpectacularRedocView errors because set_query_parameters calls urlls.parse.urlparse on url which may not be a string but a 'django.utils.functional.lazy..proxy'. Forcing url to be string fixes this issue.