Fix potential race conditions with user subscription test

tgstation · Oct 3, 2024 · d24abb5 · d24abb5
1 parent 330fbdf
commit d24abb5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/tests/Tgstation.Server.Tests/Live/HoldLastObserver.cs b/tests/Tgstation.Server.Tests/Live/HoldLastObserver.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Threading;
 
 namespace Tgstation.Server.Tests.Live
 {
@@ -10,9 +11,12 @@ sealed class HoldLastObserver<T> : IObserver<T>
 
 		public T LastValue { get; private set; }
 
-		public ulong ErrorCount { get; private set; }
+		public ulong ErrorCount => errorCount;
 
-		public ulong ResultCount { get; private set; }
+		public ulong ResultCount => resultCount;
+
+		ulong errorCount;
+		ulong resultCount;
 
 		public void OnCompleted()
 		{
@@ -21,13 +25,13 @@ public void OnCompleted()
 
 		public void OnError(Exception error)
 		{
-			++ErrorCount;
+			Interlocked.Increment(ref errorCount);
 			LastError = error;
 		}
 
 		public void OnNext(T value)
 		{
-			++ResultCount;
+			Interlocked.Increment(ref resultCount);
 			LastValue = value;
 		}
 	}

diff --git a/tests/Tgstation.Server.Tests/Live/UsersTest.cs b/tests/Tgstation.Server.Tests/Live/UsersTest.cs
@@ -53,8 +53,16 @@ await ValueTaskExtensions.WhenAll(
 
 			var expected = new PlatformIdentifier().IsWindows ? 108U : 107U;
 			// wait up to 10s
+			var lastSeen = observer.ResultCount;
 			for (var i = 0; i < 10 && observer.ResultCount < expected; ++i)
+			{
 				await Task.Delay(TimeSpan.FromSeconds(1), cancellationToken);
+				if (observer.ResultCount > lastSeen)
+				{
+					lastSeen = observer.ResultCount;
+					i = -1;
+				}
+			}
 
 			Assert.AreEqual(expected, observer.ResultCount); // sys user
 			observer.LastValue.EnsureNoErrors();