More GraphQL Work #1936
Merged
More GraphQL Work #1936
+8,128
−1,743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce the concept of `IAuthority`s to handle business logic for both REST and GraphQL. - Add new authorize attributes so roles can be defined on `IAuthority`s and inherited on REST/GraphQL API surface. - Implement `ILoginAuthority`, converting REST methods to use it. - Partially implement `IUserAuthority`, converting REST methods to use it. - Setup `ErrorMessageResponse` filtering for GraphQL fields.
- Setup query structure for the potential for `RemoteGateway`s. - Add new `ErrorCode` indicating they are not implemented. - Rename `ServerInformationBase` to `GatewayInformationBase`. - Fix `TgsRestAuthorizeAttribute` lacking an `IAuthorizationFilter`.
…ing. CBT with new API transformer procedure
Upstream documentation PR: ChilliCream/graphql-platform#7458
…that wasn't present previously. Validate nodes can be resolved
![tgstation-server-ci[bot]](https://avatars.githubusercontent.com/in/847638?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1936 +/- ##
==========================================
- Coverage 95.86% 95.65% -0.22%
==========================================
Files 744 789 +45
Lines 168673 170292 +1619
Branches 3320 3478 +158
==========================================
+ Hits 161704 162895 +1191
- Misses 6459 6858 +399
- Partials 510 539 +29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed user manager
#1077
🆑
Fixed some oddities in the authentication/authorization pipeline.
/🆑
🆑 HTTP API
Reserved error code 109 for a future change.
/🆑
🆑 Nuget: API
BREAKING: Removed
IEquatableimplementations forSwarmServers.BREAKING:
RightsHelper.RoleNamesnow returns anIEnumerable<string>instead of a comma separatedstring.BREAKING: Non-functionally rearranged some class structures again.
/🆑
🆑 Nuget: Client
BREAKING: Updated
Tgstation.Server.Apito v16.0.0./:cl: