Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Gateways #1997

Merged
merged 7 commits into from
Nov 2, 2024
Merged

OAuth Gateways #1997

merged 7 commits into from
Nov 2, 2024

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Nov 2, 2024

Closes #1996

🆑
OAuth providers can now forward user tokens to clients.
/:cl:

🆑 Configuration
The new configuration version is 5.4.0
Added Gateway enum to each OAuth provider's configuration section. Can be one of Disabled (default), Enabled, or Only.
/:cl:

🆑 HTTP API
Added gatewayOnly to OAuthProviderInfo models. If true, the provider may only be used for gateway authentication. If null, the provider may NOT be used for gateway authentication.
Added endpoint /api/oauth_gateway. POSTing here with the OAuth authentication scheme will respond with a JSON object containing an accessCode for that provider IF the server is configured to allow OAuth gateways.
/:cl:

🆑 GraphQL API
Added oAuthGateway mutation which accepts the OAuth authentication and will respond with a payload containing an accessCode for that provider IF the server is configured to allow OAuth gateways.
/:cl:

🆑 Nuget: API
Updated to API version 10.11.0.
Added OAuthGatewayResponse model.
Added GatewayOnly nullable boolean field to OAuthProviderInfo.
/:cl:

🆑 Nuget: Client
Updated to API library version 16.2.0.
/:cl:

Merging with [APIDeploy][GQLDeploy][NugetDeploy]

@Cyberboss Cyberboss added Client Issue with the .NET client library Feature New functionality Security Issue pertaining to Authentication/Authorization or NTC (Never Trust the Client) Documentation Documentation updates REST The JSON REST API for server control Configuration Regarding the server setup JSON GraphQL The GraphQL API for server control labels Nov 2, 2024
@Cyberboss Cyberboss added this to the v6.12.0 milestone Nov 2, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Nov 2, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Nov 2, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 43.58974% with 44 lines in your changes missing coverage. Please review.

Project coverage is 95.60%. Comparing base (efd68c2) to head (d6a8e10).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1997      +/-   ##
==========================================
- Coverage   95.63%   95.60%   -0.03%     
==========================================
  Files         799      802       +3     
  Lines      170498   170557      +59     
  Branches     3502     3510       +8     
==========================================
+ Hits       163052   163063      +11     
- Misses       6900     6945      +45     
- Partials      546      549       +3     

@Cyberboss Cyberboss merged commit 5326596 into dev Nov 2, 2024
78 checks passed
@Cyberboss Cyberboss deleted the GitHubGateway branch November 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Issue with the .NET client library Configuration Regarding the server setup JSON Documentation Documentation updates Feature New functionality GraphQL The GraphQL API for server control REST The JSON REST API for server control Security Issue pertaining to Authentication/Authorization or NTC (Never Trust the Client) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub OAuth Gateway
1 participant